Cache field metadata during checking and planning#913
Merged
Conversation
Avoid repeated provider field metadata lookups within a checker or planner instance. Reuse checked select field metadata when constructing field qualifiers instead of immediately querying the provider again.
XN137
approved these changes
Jul 17, 2026
| fieldType != null | ||
| ? new AttributeFactory.FieldQualifier( | ||
| expr.getId(), sel.getField(), fieldType, adapter) | ||
| : attrFactory.newQualifier(opType, expr.getId(), sel.getField()); |
Contributor
There was a problem hiding this comment.
i assume this change avoids a redundant provider.findFieldType call in AttrFactory.newQualifier ?
is the field lookup that expensive to be worth kind of breaking the factory abstraction?
Member
Author
There was a problem hiding this comment.
It's a bit of repeated work, yea.
| Type opType = typeMap.get(sel.getOperand().getId()); | ||
| if (opType != null && !opType.getMessageType().isEmpty()) { | ||
| FieldType ft = provider.findFieldType(opType.getMessageType(), sel.getField()); | ||
| FieldType ft = findFieldType(opType.getMessageType(), sel.getField()); |
Contributor
There was a problem hiding this comment.
i assume its not worth caching negative lookup results?
(i have no idea how frequently this gets called and how expensive provider.findFieldType is)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid repeated provider field metadata lookups within a checker or planner instance. Reuse checked select field metadata when constructing field qualifiers instead of immediately querying the provider again.